Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Add Noise2DNode, Noise3DNode, Fractal3DNode. #21800

Merged
merged 3 commits into from
May 12, 2021

Conversation

donmccurdy
Copy link
Collaborator

Names and parameters following the MaterialX noise specification, but omitting cell noise and worley noise for now. GLSL from https://github.com/ashima/webgl-noise (MIT License).

Changes:

  • ✅ Add Noise2DNode: 2D Perlin noise.
  • ✅ Add Noise3DNode: 3D Perlin noise.
  • ✅ Add Fractal3DNode: 3D Fractional Brownian noise, created by summing several octaves of 3D Perlin noise, increasing the frequency and decreasing the amplitude at each octave.
  • ❌ Remove NoiseNode.

Related issue: #20541

/cc @sunag

Screen Shot 2021-05-07 at 3 40 20 PM

@mrdoob mrdoob added this to the r129 milestone May 8, 2021
@mrdoob mrdoob requested a review from sunag May 8, 2021 07:35
@Mugen87
Copy link
Collaborator

Mugen87 commented May 8, 2021

FYI #21801

@donmccurdy
Copy link
Collaborator Author

I'd also be fine with keeping the existing noise node — is it simplex noise? — with a more specific name. I didn't see it used anywhere currently, though, and so assumed it was probably fine to remove in favor of these options from MaterialX.

@mrdoob mrdoob requested a review from sunag May 10, 2021 11:44
@mrdoob
Copy link
Owner

mrdoob commented May 12, 2021

Thanks!

@donmccurdy donmccurdy deleted the feat-noise-nodes branch May 12, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants