Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRT clean up #21792

Merged
merged 3 commits into from
May 6, 2021
Merged

MRT clean up #21792

merged 3 commits into from
May 6, 2021

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented May 6, 2021

Related issue: #16390

Description

Some internal code clean up.

@takahirox looks good?

@mrdoob mrdoob added this to the r129 milestone May 6, 2021
@gkjohnson
Copy link
Collaborator

If you're going to rename the example from _mrt to _multiple_rendertargets you might want to add mrt as a tag for the example. "MRT" is how I refer to and search around for references on the feature, at least.

@mrdoob
Copy link
Owner Author

mrdoob commented May 6, 2021

@gkjohnson done!

@takahirox
Copy link
Collaborator

@takahirox looks good?

I couldn't look into the detail yet but the clean up basically looks good!
And thanks for fixing some bugs that I had forgotten to rename isWebGLMultiRenderTarget to isWebGLMultipleRenderTargets.

@mrdoob
Copy link
Owner Author

mrdoob commented May 6, 2021

It's mostly renames and readability.
Considering that all the tests passed I'll merge, we can tweak things if you find something.

@mrdoob mrdoob merged commit 5dd3e7c into dev May 6, 2021
@mrdoob mrdoob deleted the mrt branch May 6, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r129
Development

Successfully merging this pull request may close these issues.
3 participants
@mrdoob @gkjohnson @takahirox