Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineGeometry: Remove "copy" function override #21782

Merged
merged 1 commit into from
May 5, 2021

Conversation

gkjohnson
Copy link
Collaborator

Related issue: --

Description

Removes the unimplemented LineGeometry.copy override which prevented the function from working. Related to #21781.

cc @WestLangley is there a reason you expected this to require a custom implementation?

@WestLangley
Copy link
Collaborator

@WestLangley is there a reason you expected this to require a custom implementation?

I do not recall. But this PR appears correct to me with #21781.

Thanks!

@mrdoob mrdoob added this to the r129 milestone May 5, 2021
@mrdoob mrdoob merged commit 6ccec8f into mrdoob:dev May 5, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 5, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request May 8, 2021
11 tasks
@gkjohnson gkjohnson deleted the fix-linegeometry-copy branch May 10, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants