WebGLRenderer: Remove deprecated parameters check for render() #21777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
commented
May 4, 2021
Mugen87
approved these changes
May 4, 2021
|
Thanks! |
9 tasks
|
Added a note in the migration guide. Please feel free to correct my English as usual. https://github.com/mrdoob/three.js/wiki/Migration-Guide#128--129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #15571, especially #15571 (comment)
Description
We removed the third and forth arguments from
WebGLRenderer.render(), and added deprecated parameters check for the backward compatibility in #15571.Two years has past since we removed the parameters. I think it would be ok to remove the deprecated parameters check.
The benefits
arguments[2, 3](if major JIT compilers still allocate memory for it every frame)I would like to add a note in the migration guide about the removal if this PR gets merged