Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move onUploadCallback back to prototype scope #21770

Merged
merged 1 commit into from
May 2, 2021
Merged

Move onUploadCallback back to prototype scope #21770

merged 1 commit into from
May 2, 2021

Conversation

kaisalmen
Copy link
Contributor

@kaisalmen kaisalmen commented May 2, 2021 •
edited by Mugen87
Loading

Fixed #21769

Description

As suggested in linked issue this PR moves back onUploadCallback to the prototype scope in BufferAttribute and InterleavedBuffer. Tests executed locally are ok with the change.

@kaisalmen kaisalmen mentioned this pull request May 2, 2021
Closed
7 tasks
@Mugen87 Mugen87 merged commit 43b59f9 into mrdoob:dev May 2, 2021
@Mugen87 Mugen87 added this to the r129 milestone May 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r129
Development

Successfully merging this pull request may close these issues.

BufferAttribute.onUploadCallback was moved out of prototype scope
3 participants
@kaisalmen @mrdoob @Mugen87