Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineSegments2: Fix typo in raycast #21760

Merged
merged 2 commits into from
May 1, 2021

Conversation

amosbyon1224
Copy link
Contributor

Description

Raycast code for LineSegment2 was broken in my project when updating to r128. Taking a look it seems like there was a mix-up between _start and _start4 as well as _end and _end4.

The following commit should fix the bug and raycasting with LineSegment2 should work again!

@Mugen87 Mugen87 merged commit 9b978eb into mrdoob:dev May 1, 2021
@amosbyon1224 amosbyon1224 deleted the fix-linesegments2-raycast branch May 1, 2021 08:08
@mrdoob
Copy link
Owner

mrdoob commented May 3, 2021

Thanks!

@mrdoob mrdoob added this to the r129 milestone May 3, 2021
@joshuaellis joshuaellis mentioned this pull request May 8, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants