-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USDZExporter: Store only unique geometry and reference it #21749
Conversation
Excellent! Thanks! |
Out of curiosity, why do we need to store them in a different file? |
If we'll add geometry to the "output" - it will be instantiated in zero point. And we will see geometry itself in zero point + instantiated objects in correct places. We have multiple solutions:
Note: not all of the features of USDZ format are implemented or work in AR QuickLook. |
Yes, I was thinking if that would be better. I found it weird when I tested this and I saw the geometry.usd file with all geometries on top of each other. Makes it hard to debug.
I think it'd be worth it. |
@mrdoob
Basically my proposal - store geometry ID in file names (similar to current textures storage). And inside the file we will only use "Geometry" word without ID. |
The proposed approach looks great to me 👍 |
Fixed #21748
Description
Now we are storing only unique geometries in different geometry.usd file.
model.usda have only references to geometries (meshes).
Also, geometry do not store material references. Xforms from model.usda now do it.
It could help us with storing of many identical objects but with different materials binded