Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the original camera view offset inside SSAARenderPass. #21740

Merged
merged 7 commits into from
May 1, 2021
Merged

Respect the original camera view offset inside SSAARenderPass. #21740

merged 7 commits into from
May 1, 2021

Conversation

msimpson
Copy link
Contributor

@msimpson msimpson commented Apr 28, 2021 •
edited
Loading

Respect the original camera view offset inside SSAARenderPass.

Add a viewOffsetX GUI param to the webgl_postprocessing_ssaa example.

Fixes #21735.

@msimpson
Respect the original camera view offset inside SSAARenderPass.
fda1509 
Add a viewOffsetX GUI param to the webgl_postprocessing_ssaa example.
@msimpson
Copy link
Contributor Author

@Mugen87

Unless there are any objections, I'm considering this complete.

msimpson
msimpson commented Apr 29, 2021
View reviewed changes
Copy link
Contributor Author

@msimpson msimpson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I streamlined things further given Object.assign( {}, null ) behaves in the same fashion.

As originalViewOffset will at the least become an empty object, I can drop the null checks and work from enabled alone.

@Mugen87 Mugen87 added this to the r129 milestone May 1, 2021
@Mugen87 Mugen87 merged commit f924198 into mrdoob:dev May 1, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r129
Development

Successfully merging this pull request may close these issues.

SSAARenderPass does not respect the original view object of the PerspectiveCamera.
3 participants
@msimpson @mrdoob @Mugen87