Use Instanced Meshes in XRHandPrimitiveModel.js #21702
Conversation
|
Merging this so it gets in r128 👍 |
| } | ||
|
|
||
| this.handMesh.count = count; | ||
| if ( this.handMesh.instanceMatrix ) { |
There was a problem hiding this comment.
Oops, yes; good spot!
That must have been a bit of vestigial superstition creeping in :-)
(EDIT: Aha, it was because I was burnt by unintialized color arrays before, but it seems like the matrix array is always initialized in the constructor, so it will always return true.)
|
|
||
| } | ||
| this.handMesh = new InstancedMesh( geometry, jointMaterial, 30 ); |
There was a problem hiding this comment.
I honestly do not know how much this does, but I guess it would be good practice to add this?
this.handMesh.instanceMatrix.setUsage( THREE.DynamicDrawUsage ); // will be updated every frameThere was a problem hiding this comment.
I didn't know about this one; that does seem appropriate here. Thank you for letting me know about it!
I just tested it in a Quest 1 and I don't notice any additional perceptual framerate benefits, but perhaps it's something subtle like segregating the arrays to more volatile GPU memory, or reducing contention when interacting with other drawcalls somehow...
|
Here's the clean up: 8e50d5c |
|
I broke it... |
|
Well, that was silly... c179013 |
This PR switches the simple
XRHandPrimitiveModelscript to use theInstancedMeshclass to draw the hand in a single drawcall.Since OpenXR hands are only supported on the Oculus Quest, every drawcall is precious.
I've enjoyed a noticeable framerate improvement by switching to this rendering mode.
https://raw.githack.com/zalo/three.js/feat-instanced-hands/examples/?q=handinput