Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move envMapIntensity, envMapIntensity, refractionRatio outside of env… #21701

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

jimi75
Copy link
Contributor

@jimi75 jimi75 commented Apr 22, 2021

Description

After the implementation of scene.environment #18218 it is possible for a material to use parameters from an envMap without having to have a specific envMap assigned to it.

This PR move envMapIntensity, reflectivity & refractionRatio in Material.toJSON() outside of the conditional that check for an existence of explicit envMap in the material

@mrdoob
Copy link
Owner

mrdoob commented Apr 23, 2021

Good catch!

@mrdoob mrdoob added this to the r128 milestone Apr 23, 2021
@mrdoob mrdoob merged commit 5a0a094 into mrdoob:dev Apr 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 23, 2021

Gràcies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants