Make WASM path configurable + Update IFC library #21683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the example is not working anymore: https://raw.githack.com/agviegas/three.js/IfcLoader/examples/webgl_loader_ifc.html
|
Mugen87
reviewed
Apr 19, 2021
|
It is working on my end now. Let me know if there is anything else to correct! |
|
Thanks! |
|
The trees are no longer red (and e2e didn't caught this...) 🤔
|
|
Hum, probably the trees are not red anymore because of the last advances regarding IFC material reading (I think that red was a default case). If it's not urgent, I can update the shot of the example in the next PR (which will be soon). |
|
No worries! I'll update the screenshot now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #21673
Description
This solves the route to the WASM file as a setter of IfcLoader, so the end user can put it wherever they prefer. Also, I have updated the web-ifc library to the latest version.