Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Refactor Sky usage. #21681

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Examples: Refactor Sky usage. #21681

merged 3 commits into from
Apr 20, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 19, 2021 •
edited by WestLangley
Loading

Related issue: Alternative implementation for #21575.

Description

Uses elevation instead of inclination in webgl_shaders_ocean and webgl_shaders_sky.

Both elevation and azimuth are now expressed in degress.

Range of elevation is [0,90]. Range of azimuth is [-180,180].

@Mugen87 Mugen87 closed this Apr 19, 2021
@Mugen87 Mugen87 reopened this Apr 19, 2021
@mrdoob mrdoob added this to the r128 milestone Apr 20, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2021

@Mugen87 Resolved the conflicts. Looks good?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 20, 2021

Yep! 😊

@mrdoob mrdoob merged commit 1dd66f3 into mrdoob:dev Apr 20, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r128
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob