MathUtils: convert to esmodules to allow for tree-shaking #21651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting... |
|
Thanks! |
jonnycornwell
added a commit
to jonnycornwell/DefinitelyTyped
that referenced
this pull request
May 19, 2021
- It has been updated and no longer exports a namespace, see mrdoob/three.js#21651 - The following: import { MathUtils } from 'three/src/math/MathUtils'; results in a runtime error as MathUtils will be undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This is the pattern to use if we want to allow for tree-shaking for the util-functions files. The API of
MathUtilsdoes not change, just the import internally changes.The downside is: you can't add methods dynamically from outside the file. It was being done in
Three.Legacy.js, and I had to remove the methods there.