Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-treeshake: use terser for minification #21650

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

marcofugaro
Copy link
Contributor

Related issue: -

Description

We were using rollup-plugin-filesize to show the minified size in the test-treeshake script. However the minified sized were skewed because it was calculating them internally.

I've updated the script to use terser to compute the minified size. Terser is what most people use nowadays to minify, so it's more accurate.

The script now produces index.bundle.min.js and an unminified index.bundle.js for human inspection, this is the new output:

@mrdoob mrdoob added this to the r128 milestone Apr 14, 2021
@mrdoob mrdoob merged commit 10a33e1 into mrdoob:dev Apr 14, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants