New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCodeLoader ES6 variables (let/const) #21630

Merged

mrdoob merged 3 commits into mrdoob:dev from tentone:gcodeloader-es6

Apr 10, 2021

Contributor

tentone commented Apr 10, 2021 •

edited by Mugen87

Loading

Related issue: #21616

Implemented the usage of let/const in the GCodeLoader.
Fixed a small typo in the code that was reading the extruding state from line instead of using the state object.
Mino reorganization of code to ensure access to all vars.

tentone added 3 commits

April 9, 2021 17:21


          Clean up

97287b8


          Clean up

802508c


          Const

8bf2fb9

Mugen87 approved these changes

View reviewed changes

Mugen87 added this to the r128 milestone

mrdoob merged commit ce16713 into mrdoob:dev

Owner

mrdoob commented Apr 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet