Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Remove XLoader. #21617

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Examples: Remove XLoader. #21617

merged 2 commits into from
Apr 9, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 9, 2021

Related issue: -

Description

The code structure to XLoader is very different compared to all other loaders in the repo. Converting the code to proper ES6 would require a rewrite from scratch. Since the original dev does not maintain the loader anymore, I think it's better to remove it instead of investing a lot of time in it. Considering the relevance of the X file format, I think it's appropriate to make this step.

@mrdoob
Copy link
Owner

mrdoob commented Apr 9, 2021

Sounds good to me 👍

@mrdoob mrdoob added this to the r128 milestone Apr 9, 2021
@mrdoob mrdoob merged commit 8f6cc7d into mrdoob:dev Apr 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 9, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request Apr 15, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants