Examples: Convert effects to ES6. #21610
Conversation
|
|
||
| scene.updateMatrixWorld(); | ||
| this.render = function ( scene, camera ) { |
There was a problem hiding this comment.
The internal variables could be defined outside of the class like here, scope can be replaced just by this, and render and setSize could become class methods, no?
There was a problem hiding this comment.
I'm not sure this kind of refactoring is wanted. It requires that a lot of variables are added to the public namespace so they are accessible by all methods.
If the current code structure does not interfere with tree-shaking, I would like to avoid changing it (and just develop new classes differently).
There was a problem hiding this comment.
It requires that a lot of variables are added to the public namespace
Public namespace? ES modules are locally scoped 😇
There was a problem hiding this comment.
I mean variables are defined in the constructor's scope. It would be necessary to add them to this.
There was a problem hiding this comment.
@marcofugaro Don't mess with Mugen's flow! 😁 Feel free to do a second pass later 😉
There was a problem hiding this comment.
okay! didn't mean to criticize Mugen's work in any way 😄 those ES6 PRs are awesome! keep it up!
There was a problem hiding this comment.
I'm totally fine when this is revisited at a later point. @marcofugaro Feel free to tackle this if you like 😊 .
|
Thanks! |
Related issue: -
Description
Converts the
effectsdirectory to ES6 syntax.