Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Fix ImmediateRenderObject with vertex colors. #21602

Merged
merged 1 commit into from
Apr 23, 2021
Merged

WebGLRenderer: Fix ImmediateRenderObject with vertex colors. #21602

merged 1 commit into from
Apr 23, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 7, 2021

Related issue: -

Description

The vertex color alpha addition has broken ImmediateRenderObject with vertex colors. This can be demonstrated by choosing the colors and multiColors preset of webgl_marchingcubes.

Since ImmediateRenderObject has no geometry property, it's necessary to add an additional check at two places in the renderer.

@Mugen87 Mugen87 added this to the r128 milestone Apr 10, 2021
@mrdoob mrdoob merged commit c1d2e49 into mrdoob:dev Apr 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 23, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r128
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob