Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build-examples script on windows #21591

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Fix build-examples script on windows #21591

merged 2 commits into from
Apr 6, 2021

Conversation

marcofugaro
Copy link
Contributor

@marcofugaro marcofugaro commented Apr 6, 2021 •
edited
Loading

Related issue: #21588 #20844

Description

Make the build-examples script work on windows as well, basically replacing \n with os.EOL.

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 6, 2021

Nit: https://lgtm.com/projects/g/mrdoob/three.js/snapshot/58177922839832e4ec135ef5e16648b4e407207e/files/utils/build/rollup.examples.config.js?sort=name&dir=ASC&mode=heatmap#x559baa7b97df070:1

This can be fixed with another PR.

@marcofugaro
Copy link
Contributor Author

That warning was actually useful, fixed!

@mrdoob mrdoob added this to the r128 milestone Apr 6, 2021
@mrdoob mrdoob merged commit 3bc0f1a into mrdoob:dev Apr 6, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 6, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r128
Development

Successfully merging this pull request may close these issues.
3 participants
@marcofugaro @Mugen87 @mrdoob