Examples: Convert cameras and geometries to ES6.

[Mugen87]

Related issue: -

Description

More usage of ES6 syntax.

[Mugen87]

@marcofugaro When executing the conversion script on my branch, this pops up:

/Users/Michael/Documents/workspace/three.js/examples/js/exporters/USDZExporter.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/3MFLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/AMFLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/EXRLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/FBXLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/KMZLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/NRRDLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/TiltLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

/Users/Michael/Documents/workspace/three.js/examples/js/loaders/VTKLoader.js
  2:1  error  Parsing error: 'import' and 'export' may only appear at the top level

It seems the script misses to remove the following import statement. At least on my computer:

import * as fflate from '../libs/fflate.module.min.js';

[marcofugaro]

@Mugen87 you're on windows right?

It is probably the \n not matching in these replaces, could you test that it doesn't happen if you remove the \n?

three.js/utils/build/rollup.examples.config.js

Lines 116 to 121 in d9a5084

	code = code.replace( 'import * as fflate from \'../libs/fflate.module.min.js\';\n', '' );
	code = code.replace( 'import { MMDParser } from \'../libs/mmdparser.module.js\';\n', '' );
	code = code.replace( 'import { potpack } from \'../libs/potpack.module.js\';\n', '' );
	code = code.replace( 'import { opentype } from \'../libs/opentype.module.min.js\';\n', '' );
	code = code.replace( 'import { chevrotain } from \'../libs/chevrotain.module.min.js\';\n', '' );
	code = code.replace( 'import { ZSTDDecoder } from \'../libs/zstddec.module.js\';\n', '' );

[marcofugaro]

The \n can be safely removed, there is a trimStart() call after. I'll make a PR if you confirm the source of the problem.

[Mugen87]

you're on windows right?

I'm on macOS right now.

[marcofugaro]

@Mugen87 tested your branch and the issue doesn't happen on my machine.

Could you help me debug this particular line on your machine? 🙏
Why this particular replace doesn't work?

three.js/utils/build/rollup.examples.config.js

Line 116 in d9a5084

code = code.replace( 'import * as fflate from \'../libs/fflate.module.min.js\';\n', '' );

[Mugen87]

The strange thing is import * as fflate from '../libs/fflate.module.min.js'; gets replaced with:

import { unzipSync } from '../libs/fflate.module.min.js';

And then the linter complains. Not sure why this happens yet.

[Mugen87]

I've removed my node_modules folder and made a fresh npm i. Now it seems to work!

[marcofugaro]

@Mugen87 it's probably rollup, could you run a npm install to make sure you have the correct version?

I have this version:

[Mugen87]

Yep, using this version solved the issue.

[mrdoob]

Thanks!