Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTexture: Fix updateMultisampleRenderTarget(). #21570

Merged
merged 2 commits into from
Apr 4, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 3, 2021

Related issue: Fixed #21569.

Description

Honor the fact that gl.DRAW_FRAMEBUFFER is equivalent to gl.FRAMEBUFFER.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 3, 2021

@vanruesc Do you mind testing this change, too? The warning in your example should disappear.

@vanruesc
Copy link
Contributor

vanruesc commented Apr 3, 2021

Tested it just now and can confirm the warning is gone 👍

@Mugen87 Mugen87 merged commit bb11881 into mrdoob:dev Apr 4, 2021
@Mugen87 Mugen87 added this to the r128 milestone Apr 4, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGLMultisampleRenderTarget causes blit feedback loop
3 participants