Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Clean up. #21552

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Examples: Clean up. #21552

merged 2 commits into from
Mar 31, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 31, 2021

Related issue: -

Description

Removed the animation loop in webgl_loader_ifc and structured the code similar to the other examples.

It also fixes the path to the core library in IFCLoader.

@@ -14,7 +14,7 @@ import {
InterleavedBuffer,
InterleavedBufferAttribute,
BufferAttribute,
} from '../../../../build/three.module.js';
} from '../../../build/three.module.js';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops! Can't wait for Import Maps...

@mrdoob mrdoob added this to the r128 milestone Mar 31, 2021
@mrdoob mrdoob merged commit 51afad9 into mrdoob:dev Mar 31, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2021

/fyi @agviegas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants