RoughnessMipmapper: Preserve texture UV transform #21511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoughnessMipmapper created a new texture and replaced existing material textures with the copy - however, the copy didn't inherit the UV transform properties from the source. This could be problematic when for example the roughness map came from the glTF file that used KHR_texture_transform extension. When rendered with standard three.js material this by itself would not be a problem since three.js only supports one shared transform for most material maps but when the user overrode the material with a custom one (which happens inside model-viewer as far as I can tell), the incorrect offset/repeat values in the cloned texture could result in incorrect rendering.
|
Thanks! |
|
/fyi @elalish |
|
FYI: |
|
@Mugen87 No need to look into that. It's actually a bug in Chrome. /nudge @kenrussell |
|
Oh, thanks for the hint. That saved me some time 😅 . |
|
Apologies for the Chromium side bug. Is it this one? Incomplete texture reported in copyTexImage2D loop in Three.js |
|
I think so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoughnessMipmapper created a new texture and replaced existing material
textures with the copy - however, the copy didn't inherit the UV
transform properties from the source.
This could be problematic when for example the roughness map came from
the glTF file that used KHR_texture_transform extension. When rendered
with standard three.js material this by itself would not be a problem
since three.js only supports one shared transform for most material maps
but when the user overrode the material with a custom one (which
happens inside model-viewer as far as I can tell), the incorrect
offset/repeat values in the cloned texture could result in incorrect
rendering.
This was originally reported in zeux/meshoptimizer#251, cc @Bketting