Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some picking/raycast examples for touch devices #21494

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

Oletus
Copy link
Contributor

@Oletus Oletus commented Mar 22, 2021

TrackballControls and OrbitControls listen to pointer events, which can cause mouse events not to fire on Android devices. Fix some picking examples by listening to pointer events in them as well.

This contribution is funded by Higharc.

TrackballControls and OrbitControls listen to pointer events, which can cause mouse events not to fire on Android devices. Fix some picking examples by listening to pointer events in them as well.
@mrdoob mrdoob added this to the r127 milestone Mar 22, 2021
They're redundant - all modern browsers support pointer events.
@mrdoob mrdoob merged commit 19bb1ae into mrdoob:dev Mar 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 23, 2021

Thanks!

@Oletus Oletus deleted the picking-example-fixes branch March 23, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants