Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quaternion: Use Number.EPSILON in setFromUnitVectors(). #21484

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 18, 2021

Related issue: Fixed #21477.

Description

Use Number.EPSILON instead of 0.000001 as epsilon value.

@mrdoob mrdoob added this to the r127 milestone Mar 18, 2021
@mrdoob mrdoob merged commit a3114f0 into mrdoob:dev Mar 18, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 18, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quaternion.setFromUnitVectors lacks precision for close to opposite vectors
2 participants