Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line/Points: Support drawRange in raycast(). #21481

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 18, 2021

Related issue: Fixed #8479.

Description

This PR adds drawRange support to Line.raycast() and Points.raycast(). Since using groups in context of points and lines is not that common, I think this is a fair tradeoff for #8479.

Besides, since the Geometry removal noticeably simplified raycast() methods, I think it's okay to add this bit of complexity.

@mrdoob mrdoob added this to the r127 milestone Mar 19, 2021
@mrdoob mrdoob merged commit 3c7d515 into mrdoob:dev Mar 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lines/Points: Raycast ignores BufferGeometry drawRange and groups
2 participants