Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVGLoader: Apply default values when using getAttribute(). #21469

Merged
merged 1 commit into from
Mar 15, 2021
Merged

SVGLoader: Apply default values when using getAttribute(). #21469

merged 1 commit into from
Mar 15, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 15, 2021

Related issue: see 330b186#commitcomment-48264586

Description

That fixes the broken Defs and Defs2 tests.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 15, 2021

Used the initial values from https://www.w3.org/TR/SVG2/shapes.html.

@mrdoob mrdoob added this to the r127 milestone Mar 15, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2021

Good catch!

@mrdoob mrdoob merged commit 9c71f71 into mrdoob:dev Mar 15, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2021

Thanks!

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Mugen87 referenced this pull request Mar 16, 2021
@mrdoob
Curves: Clean up.
330b186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob