Examples: Clean Up

[Dvvarf]

Related issue: -

Description

This simple fix changes two instances of data.count to count, which allows any BufferAttribute to be used with LineSegments2 and Wireframe classes, not only InterleavedBufferAttribute.

Description+

Method computeLineDistances (from classes LineSegments2 and Wireframe) expected instanceStart and instanceEnd to have data.count property, but this property only exists on InterleavedBufferAttribute class. At the same time InterleavedBufferAttribute exposes count property (passed-through data.count property) which corresponds to count property from BufferAttribute.

[WestLangley]

@Dvvarf This change is an improvement, but I'm wondering if it is correct to say the class now "supports BufferAttribute"...

Can you please explain what, exactly, are you doing in your app?

[Dvvarf]

@WestLangley I agree that stating support for BufferAttribute is a bit much, I've only tried to use it with InstancedBufferAttribute. I'm not sure about that, but I believe it was intended to be only used with instanced buffers... Perhaps a check should be added for this.

For me using InterleavedBufferAttribute is not convenient as I has an array of points with array of line lengths and not looking to double my memory usage. Turned out that it was entirely possible to directly use LineSegmentsGeometry, manually setting it's instanceStart and instanceEnd attributes. That's when I tried to use InstancedBuffer and encountered an error in LineSegments2, because it doesn't have data property, but has count. Applying this quick fix solved the problem.

[WestLangley]

Agreed, I do not think you are adding additional functionality.

@gkjohnson Does this change look OK to you?

[gkjohnson]

@gkjohnson Does this change look OK to you?

Yeah this looks good since it's just pass through. The raycast code already uses instanceStart.count so this should make things more consistent, as well.

Demos look good, too:

https://raw.githack.com/Dvvarf/three.js/dev/examples/webgl_lines_fat.html

https://raw.githack.com/Dvvarf/three.js/dev/examples/webgl_lines_fat_wireframe.html

[mrdoob]

Thanks!