Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Refactor framebuffer state management. #21447

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 11, 2021

Related issue: -

Description

This PR moves the framebuffer management from WebGLRenderer to WebGLState. It also removes WebGLRenderer.setFramebuffer() which was always a bit of a hack any only introduced because of XR. As a replacement, WebXRManager can now use WebGLState.bindXRFramebuffer(). All other logic in the renderer uses WebGLState.bindFramebuffer().

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 11, 2021

Tested this change with Oculus Quest (especially the sandbox example with the mirror).

@mrdoob mrdoob added this to the r127 milestone Mar 11, 2021
@mrdoob mrdoob merged commit e903c84 into mrdoob:dev Mar 11, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants