Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Fix rendering of line segments. #21443

Merged
merged 1 commit into from
Mar 10, 2021
Merged

WebGPURenderer: Fix rendering of line segments. #21443

merged 1 commit into from
Mar 10, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 10, 2021 •
edited
Loading

Related issue: see #21208 (comment)

Description

Line segments rendering was broken because of a wrong evaluation of isLineSegments in WebGPURenderPipelines. The problem is that isLine is true for all an instances of LineSegments 🤦‍♂️.

@Mugen87 Mugen87 merged commit 12fdefa into mrdoob:dev Mar 10, 2021
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 10, 2021

Thanks to @kainino0x for pointing me in the right direction 👍 .

@Mugen87 Mugen87 added this to the r127 milestone Mar 10, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 10, 2021 •
edited
Loading

Remember to Squash & Merge instead of Merge 🙏

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Mar 11, 2021

I've totally forgot that Squash & Merge also makes sense with PRs with just one commit^^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob