Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLState: Change viewport and scissor setup. #21440

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 10, 2021

Related issue: -

Description

The default dimensions of the viewport and scissor box are the width and height of the canvas.

initGLContext() performs a redundant state configuration right after creating WebGLState. Instead of doing this, one can setup the cached scissor and viewport variables in WebGLState with the true defaults to achieve the same internal state as before.

@mrdoob mrdoob added this to the r127 milestone Mar 10, 2021
@mrdoob mrdoob merged commit f5c6b1c into mrdoob:dev Mar 10, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants