Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resize issue in OutlinePass #21436

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix resize issue in OutlinePass #21436

merged 1 commit into from
Mar 9, 2021

Conversation

Julianouyang
Copy link
Contributor

Related issue: #XXXX

Description

This PR fixes an issue when resolution is passed as 0x0. The resize function couldn't properly resize renderTargetDepthBuffer, and it certainly breaks the outline effect.

@Julianouyang
Copy link
Contributor Author

Off-topic but for discussion:
I found some posts that complained OutlinePass not working with white background (because of the blending). In my app I added an option to turn off the hidden outline, by changing the related shader. It's also useful if users don't want to see the hidden outline. Let me know if this is worth sharing.

@mrdoob mrdoob added this to the r127 milestone Mar 9, 2021
@mrdoob mrdoob merged commit 976404a into mrdoob:dev Mar 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
3 participants
@Julianouyang @mrdoob @Mugen87