Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make applyMatrix4 work on a BufferGeometry with InterleavedBufferAttribute normals. #21434

Merged
merged 2 commits into from
Mar 21, 2021

Conversation

devnev
Copy link
Contributor

@devnev devnev commented Mar 8, 2021

Closes #21433

Description

Allow applyMatrix4 to be called on a BufferGeometry with normal or tangent attributes from an InterleavedBufferAttribute by adding the applyNormalMatrix and transformDirection methods. Method implementations are copied from BufferAttribute.

@WestLangley
Copy link
Collaborator

Sweet. Do you mind also updating the doc file?

@devnev
Copy link
Contributor Author

devnev commented Mar 12, 2021

@Mugen87 @WestLangley is there anything else I should do for this to be merged?

@Mugen87 Mugen87 added this to the r127 milestone Mar 16, 2021
@Mugen87 Mugen87 merged commit bfc15ba into mrdoob:dev Mar 21, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BufferGeometry.applyMatrix4 throws for normals from InterleavedBufferAttributes
4 participants