Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerspectiveCamera and CinematicCamera: Convert to ES6 class. #21426

Closed
wants to merge 12 commits into from

Conversation

beginor
Copy link
Contributor

@beginor beginor commented Mar 7, 2021

  • PerspectiveCamera: Convert to ES6 class
  • CinematicCamera: Convert to ES6 class

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 7, 2021

Sorry, but CinematicCamera can't be converted since it exists in examples/js.

@Mugen87 Mugen87 closed this Mar 7, 2021
@beginor
Copy link
Contributor Author

beginor commented Mar 8, 2021

if CinematicCamera can't be converted to es6, it looks PerspectiveCamera can not be converted to es6 too, Could you please tell me why we can not the classes in examples/js?

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 8, 2021

The example modules are mostly generated from examples/js files. The script which does the conversion does not support classes. Besides, examples/js should also work in older browsers. The following PR needs to solved first before the class conversion can be finalized: #20527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants