Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayCamera: Convert to es6 class. #21407

Merged
merged 9 commits into from
Mar 5, 2021
Merged

ArrayCamera: Convert to es6 class. #21407

merged 9 commits into from
Mar 5, 2021

Conversation

beginor
Copy link
Contributor

@beginor beginor commented Mar 4, 2021 •
edited
Loading

ArrayCamera: Convert to es6 class.

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 4, 2021

The changes to PerspectiveCamera and Camera break code (e.g. since CinematicCamera is derived from PerspectiveCamera).

EventDispatcher is already converted here: #20008

PropertyBinding is already converted here: #20016

So I suggest you focus on just ArrayCamera.

@Mugen87 Mugen87 marked this pull request as draft March 4, 2021 09:24
@beginor beginor changed the title Refact some class to es6 ArrayCamera: Convert to es6 class. Mar 5, 2021
@Mugen87 Mugen87 marked this pull request as ready for review March 5, 2021 09:37
@mrdoob mrdoob added this to the r127 milestone Mar 5, 2021
@mrdoob mrdoob merged commit 5947c2d into mrdoob:dev Mar 5, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 5, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
3 participants
@beginor @Mugen87 @mrdoob