MMDLoader: Improve Animation system for PMX #21395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Mar 3, 2021
takahirox
force-pushed
the
MMDPMXAnimationImprovement
branch
from
13eb0da to
19e0cdc
Compare
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #21249
Description
This PR lets
MMDAnimationHelpersimulate PMX animation system more properly. PMX animation system is very different from Three.js animation system and it is more costly. So I added a newMMDAnimationHelperconstructor parameterpmxAnimation: boolean (default is false)and it is expected to be settrueonly if user PMX model doesn't animate correctly. If it istruethe helper does new PMX animation simulation otherwise the loader does the regular one.The PMX specification is so complex that I'm not sure if I understand correctly. So I would be very happy if Three.js MMD users test.
I worked with @ingbunga for this PR, so would the change log editor (@Mugen87 ?) add his name next to me in r127 change log if this PR is merged?