Mesh: Fix face indices in intersection object. #21394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Mar 3, 2021
Mugen87
changed the title
Mugen87
changed the title
|
Merging this and update the builds. |
|
@mrdoob I think it's worth to cherry-pick this change into master. It can be confusing for users when the face index is wrong. Unfortunately, they can't workaround this on app level. |
|
Uh oh! Okay! |
|
Sorry, my fault! Maybe a good idea to have a unit test for this use case^^. |
|
No worries! 😊 |
|
@Mugen87 Cherry-picked and republished 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I stumbled upon this
{ a: a, b: a, c: c, ... }error, looks like a copy-paste error introduced in #21161 cc @Mugen87.This could be simplified to
{ a, b, c, ... }if Three.js is targeting a recent enough version of ECMAScript?