Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlphaToCoverage Example: Make wireframe thickness consistent #21389

Merged
merged 3 commits into from
Mar 2, 2021
Merged

AlphaToCoverage Example: Make wireframe thickness consistent #21389

merged 3 commits into from
Mar 2, 2021

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Mar 2, 2021 •
edited
Loading

Related issue: #21383

Description

Adjust the ATC shader so it the wireframe lines are a consistent thickness. Thanks for adding in the alpha to coverage option!

image

cc @Mugen87 @WestLangley

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 2, 2021 •
edited
Loading

Thanks for doing this! The wireframes are now easier to compare. The crisp lines of the AtC wireframe are fantastic!

@mrdoob mrdoob added this to the r127 milestone Mar 2, 2021
@mrdoob mrdoob merged commit 8a59d96 into mrdoob:dev Mar 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 2, 2021

Thanks!

@gkjohnson gkjohnson deleted the wireframe-thickness branch March 2, 2021 16:14
@gkjohnson
Copy link
Collaborator Author

The crisp lines of the AtC wireframe are fantastic!

It looks so good!

@WestLangley
Copy link
Collaborator

Should be

uniforms: { 'thickness': { value: API.thickness } },

@gkjohnson gkjohnson mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
4 participants
@gkjohnson @Mugen87 @mrdoob @WestLangley