ReflectorForSSRPass : Fixed feedback and improved robustness #21385
Conversation
| renderer.render( scene, virtualCamera ); | ||
| this.visible = true; |
There was a problem hiding this comment.
I think it should not control its own display or not within the Reflector, and deliberately commented out the original codes.
I still hope that the display of Reflector will be controlled by the outer code.
EDIT:
Because even after this change, we still can not delete this line of code outside reflector:
Otherwise will let the reflector keep showing and cause viewing error if we turn off it in the gui.
So I think totally controlled outside would be better.
|
I'm fine with. Many thanks! |
| // this.visible = false; | ||
| renderer.render( scene, virtualCamera ); | ||
| // this.visible = true; |
There was a problem hiding this comment.
@gonnavis you're okay with leaving that commented code here?
There was a problem hiding this comment.
Oh sorry, I'm just okay with the logic. I do feel it is not good to leave comments here, but I am afraid of making too many opinions, thinking
it may can be solved in the process of merge.
@ycw Could you please remove these comments?
There was a problem hiding this comment.
Thanks!
Hello @mrdoob , I think it's okay now.
| @@ -382,10 +382,9 @@ SSRPass.prototype = Object.assign( Object.create( Pass.prototype ), { | |||
| renderer.setRenderTarget( this.beautyRenderTarget ); | |||
| renderer.clear(); | |||
| if ( this.groundReflector ) { | |||
|
|
|||
| this.groundReflector.visible = false; | |||
| this.groundReflector.doRender( this.renderer, this.scene, this.camera ); | |||
| this.groundReflector.visible = true; | |||
There was a problem hiding this comment.
Could you please restore the empty lines style too?
mrdoob
changed the title
|
Thanks! |
Description
fixed illegal feedback.
fixed defines overwrite issue.
fixed shader prop. val of
undefined.