Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXRController: Make targetRay available in hands mode #21368

Merged
merged 1 commit into from
Mar 1, 2021
Merged

WebXRController: Make targetRay available in hands mode #21368

merged 1 commit into from
Mar 1, 2021

Conversation

felixtrz
Copy link
Contributor

Issue:
WebXRController only calculates the targetRay data when controllers are active, however in oculus browser, targetRaySpace is also populated when hands are active, and this piece of data can be useful when using hands to point and select or interact with elements in VR.

This change addresses this issue by calculating the targetRay data regardless of whether hands or controllers are active input methods.

@mrdoob mrdoob added this to the r127 milestone Mar 1, 2021
@mrdoob mrdoob merged commit 80f3437 into mrdoob:dev Mar 1, 2021
@mrdoob mrdoob changed the title Making targetRay data available under hands mode WebXRController: Make targetRay available in hands mode Mar 1, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants