Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl_materials_envmaps_parallax.html : modify the color value #21363

Merged
merged 2 commits into from
Mar 15, 2021
Merged

webgl_materials_envmaps_parallax.html : modify the color value #21363

merged 2 commits into from
Mar 15, 2021

Conversation

1993heqiang
Copy link
Contributor

Description
The color value does not match the variable name.

@Mugen87 Mugen87 added this to the r127 milestone Mar 11, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 11, 2021

BTW: Do you mind regenerating the example screenshot via npm run make-screenshot webgl_materials_envmaps_parallax?

The E2E test works however the visual appearance of the example has still changed.

@mrdoob
Copy link
Owner

mrdoob commented Mar 11, 2021

@1993heqiang
Copy link
Contributor Author

BTW: Do you mind regenerating the example screenshot via npm run make-screenshot webgl_materials_envmaps_parallax?

The E2E test works however the visual appearance of the example has still changed.

I have regenerated the screenshot. 👌

@Mugen87 Mugen87 merged commit e5955de into mrdoob:dev Mar 15, 2021
@1993heqiang 1993heqiang deleted the local_dev branch March 15, 2021 12:51
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants