Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Move invocation of Scene.onAfterRender(). #21362

Merged
merged 1 commit into from
Feb 26, 2021
Merged

WebGLRenderer: Move invocation of Scene.onAfterRender(). #21362

merged 1 commit into from
Feb 26, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 26, 2021 •
edited
Loading

Related issue: Fixed #17761.

Description

The reason for this change is explained in #17710.

scene.onAfterRender must be called after multiview or multisampled rendertargets do their blitFramebuffer for post proc to have valid data in the renderTarget.

The original PR was hard to test because it contained too many changes at once. #18626 implemented one part of it. This PR is about onAfterRender(). The changes related to WebGLMutliview are not relevant anymore. And the issue in WebGLTextures should be solved via #18904.

@mrdoob mrdoob added this to the r127 milestone Feb 26, 2021
@mrdoob mrdoob merged commit 33e0a86 into mrdoob:dev Feb 26, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 26, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.

Scene.onAfterRender behavior inconsistent between WebGL context versions
2 participants
@Mugen87 @mrdoob