Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLUniforms: Add unsigned vector array support for uniform. #21316

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

SuperSodaSea
Copy link
Contributor

Description

Writing unsigned vector uniforms in shaders:

uniform uvec2 foo;

And using them can result in this exception:

TypeError: u.setValue is not a function

I checked out the code, and found that the WebGLUniforms didn't take care of UNSIGNED_INT_VEC2/3/4. This pull request add code to support them.

@WestLangley WestLangley added this to the r127 milestone Mar 29, 2021
@WestLangley
Copy link
Collaborator

@Mugen87 FYI, I added the missing milestone.

@Mugen87 Mugen87 changed the title Add unsigned vector / array support for uniform WebGLUniforms: Add unsigned vector array support for uniform. Mar 29, 2021
@mrdoob mrdoob merged commit 9eeefa6 into mrdoob:dev Mar 29, 2021
@mrdoob
Copy link
Owner

mrdoob commented Mar 29, 2021

Thanks!

@SuperSodaSea SuperSodaSea deleted the unsigned-uniform branch September 10, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants