Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Adds generateMipMaps option to WebGLRenderTarget #21306

Merged
merged 2 commits into from
Feb 18, 2021
Merged

docs: Adds generateMipMaps option to WebGLRenderTarget #21306

merged 2 commits into from
Feb 18, 2021

Conversation

gsimone
Copy link
Contributor

@gsimone gsimone commented Feb 18, 2021

Fixes #21304

@mrdoob
Copy link
Owner

mrdoob commented Feb 18, 2021

Not sure we want to add Set this to true if you need it. to all booleans in the documentation 😅

@mrdoob mrdoob added this to the r126 milestone Feb 18, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 18, 2021

Yeah, this phrase can be removed.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 18, 2021

@mrdoob How about merging this and then I clean everything up? Set this to true if you need it appears in a few documents.

@gsimone
Copy link
Contributor Author

gsimone commented Feb 18, 2021 •
edited
Loading

Should I remove it from the depthBuffer and stencilBuffer or everywhere?

EDIT: oh, @Mugen87 just saw your comment 👍

@Mugen87 Mugen87 merged commit 2bfed0b into mrdoob:dev Feb 18, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 18, 2021

I'll clean things up 👍 .

@mrdoob
Copy link
Owner

mrdoob commented Feb 18, 2021

@mrdoob How about merging this and then I clean everything up? Set this to true if you need it appears in a few documents.

Sounds good!

@Mugen87 Mugen87 mentioned this pull request Feb 18, 2021
Merged
@gsimone gsimone deleted the patch-1 branch February 18, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r126
Development

Successfully merging this pull request may close these issues.

docs: Add info about mipmaps in WebGLRenderTarget docs
3 participants
@gsimone @mrdoob @Mugen87