Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometryUtils: Fix assignment bug in computeMorphedAttributes(). #21303

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 18, 2021

Related issue: Fixed #21287

Description

The PR fixes a quite obvious bug in computeMorphedAttributes().

Side note: To me, the code was never tested with a morphed mesh otherwise the original contributor of this code should have detected this issue.

@mrdoob mrdoob added this to the r126 milestone Feb 18, 2021
@mrdoob mrdoob merged commit c52cf07 into mrdoob:dev Feb 18, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 18, 2021

Thanks!

@SntsDev
Copy link
Contributor

SntsDev commented Feb 23, 2021

@techcoder-04, @Mugen87 I'm very sorry. My fault.
I changed a variable name in the last minute to make it more meaningful and I created that bug. Thanks @Mugen87 for fixing it.

@mrdoob
Copy link
Owner

mrdoob commented Feb 24, 2021

@SntsDev It's all good. We've all been there 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError : BufferGeometryUtils.computeMorphedAttributes( mesh ) says cannot read 'getX' of undefined
3 participants