Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Make Mirror examples resizable. #21297

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Examples: Make Mirror examples resizable. #21297

merged 3 commits into from
Feb 19, 2021

Conversation

gonnavis
Copy link
Contributor

@gonnavis gonnavis commented Feb 17, 2021 •
edited
Loading

Make webgl_mirror.html and webgl_mirror_nodes.html resizable and add stats to them.

Make webgl_mirror_nodes.html consider devicePixelRatio to solve the problem of aliasing on high-pixelRaito devices.

https://raw.githack.com/gonnavis/three.js/ExamplesMirrorResizable/examples/webgl_mirror.html

https://raw.githack.com/gonnavis/three.js/ExamplesMirrorResizable/examples/webgl_mirror_nodes.html

@gonnavis gonnavis force-pushed the ExamplesMirrorResizable branch from 9e701e8 to e115ace Compare February 17, 2021 12:19
@mrdoob mrdoob changed the title Examples: Make Mirror Resizable. Examples: Make Mirror examples resizable. Feb 17, 2021
Mugen87
Mugen87 reviewed Feb 18, 2021
View reviewed changes
examples/webgl_mirror.html Outdated Show resolved Hide resolved
Mugen87
Mugen87 reviewed Feb 18, 2021
View reviewed changes
examples/webgl_mirror.html Outdated Show resolved Hide resolved
@gonnavis gonnavis force-pushed the ExamplesMirrorResizable branch from 686bf66 to f451f86 Compare February 18, 2021 10:38
@gonnavis
Copy link
Contributor Author

@Mugen87 Updated.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 18, 2021 •
edited
Loading

Make webgl_mirror_nodes.html consider devicePixelRatio to solve the problem of aliasing on high-pixelRaito devices.

In this case, BlurNode has to honor the devicePixelRatio, too.

@gonnavis gonnavis force-pushed the ExamplesMirrorResizable branch 2 times, most recently from f26e972 to 40e3a8f Compare February 18, 2021 11:11
@gonnavis
1. Directly call getRenderTarget() in onWindowResize().
126f028 
2. BlurNode also honor devicePixelRatio.
3. Remove stats.js.
@gonnavis gonnavis force-pushed the ExamplesMirrorResizable branch from 40e3a8f to 126f028 Compare February 18, 2021 11:13
@gonnavis
Copy link
Contributor Author

gonnavis commented Feb 18, 2021 •
edited
Loading

OK, made BlurNode consider devicePixelRatio.

@mrdoob mrdoob added this to the r126 milestone Feb 19, 2021
@mrdoob mrdoob merged commit 7964d9d into mrdoob:dev Feb 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r126
Development

Successfully merging this pull request may close these issues.
3 participants
@gonnavis @Mugen87 @mrdoob