Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniformUtils.cloneUniforms(): Also clone quaternions #21268

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

jure
Copy link
Contributor

@jure jure commented Feb 13, 2021

Description

UniformsUtils.clone does not clone quaternions, resulting in the same instance of a given THREE.Quaternion uniform value being reused when that is specifically not desired.

This PR proposes a fix for that - it adds a check if the property isQuaternion and clones it if it is.

@mrdoob mrdoob changed the title In cloneUniforms also clone quaternions UniformUtils.cloneUniforms(): Also clone quaternions Feb 14, 2021
@mrdoob mrdoob added this to the r126 milestone Feb 14, 2021
@mrdoob mrdoob merged commit bea15b3 into mrdoob:dev Feb 14, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants