Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Group, LOD, LineLoop, Skeleton and Sprite to es6 classes #21266

Merged
merged 2 commits into from
Feb 14, 2021
Merged

Convert Group, LOD, LineLoop, Skeleton and Sprite to es6 classes #21266

merged 2 commits into from
Feb 14, 2021

Conversation

DefinitelyMaybe
Copy link
Contributor

Related issue: #19986

Description

A couple of src/object scripts converted to classes. remake of #20658

@DefinitelyMaybe DefinitelyMaybe mentioned this pull request Feb 12, 2021
Closed
@mrdoob mrdoob added this to the r126 milestone Feb 14, 2021
@mrdoob mrdoob changed the title some objects to es6 classes Convert some objects to es6 classes Feb 14, 2021
@mrdoob mrdoob merged commit c4dc0ab into mrdoob:dev Feb 14, 2021
@mrdoob mrdoob changed the title Convert some objects to es6 classes Convert Group, LOD, LineLoop, Skeleton and Sprite to es6 classes Feb 14, 2021
@DefinitelyMaybe DefinitelyMaybe deleted the objects branch February 14, 2021 19:07
@DefinitelyMaybe DefinitelyMaybe mentioned this pull request Feb 19, 2021
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r126
Development

Successfully merging this pull request may close these issues.
5 participants
@DefinitelyMaybe @mrdoob @marcofugaro @FlorentMasson @Mugen87