NRRDLoader: Improved gzip detection code #21213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Feb 6, 2021
examples/jsm/loaders/NRRDLoader.js
Outdated
| @@ -318,7 +318,7 @@ NRRDLoader.prototype = Object.assign( Object.create( Loader.prototype ), { | |||
| parseHeader( _header ); | |||
|
|
|||
| var _data = _bytes.subarray( _data_start ); // the data without header | |||
| if ( headerObject.encoding === 'gzip' || headerObject.encoding === 'gz' ) { | |||
| if ( headerObject.encoding === 'gzip' || headerObject.encoding === 'gz' || headerObject.encoding === 'gzi' ) { | |||
There was a problem hiding this comment.
Just for my understanding: gzi is just a different name for gzip, right? It does not refer to a special compression/decompression algorithm.
There was a problem hiding this comment.
Also, seems like we could just do this?
headerObject.encoding.substring( 0, 2 ) === 'gz'
|
Do you mind updating the |
|
Thanks! |
mrdoob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NRRD files exported using some of the NRRD libraries, such as pynrrd, uses
gzias an encoding name rather thangziporgz, and these files could not be loaded previously.Here, I added
gziencoding option toexamples/jsm/loaders/NRRDLoaders.jsso it recognizesgziasgzipencoding.