Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fix toJSON() methods for certain node classes. #21211

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 5, 2021

Related issue: Fixed #19878.

Description

TimerNode and VelocityNode did not implement their toJSON() method correctly since they missed to call the super method of their upper class. Hence, certain properties missed in the JSON file and produced undefined values during the deserialization process. That happened because the copy() of both classes use the respective super method to copy values from the upper class.

I've also updated the JSON files by removing the deprecated TimerNode.useTimeScale property.

@Mugen87 Mugen87 requested a review from sunag February 5, 2021 18:49
@mrdoob mrdoob added this to the r126 milestone Feb 5, 2021
@mrdoob mrdoob merged commit d001b22 into mrdoob:dev Feb 6, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 6, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unset uniforms with NodeMaterial
3 participants